Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test filters context map & message builder #4886

Merged
merged 9 commits into from
Oct 13, 2023
Merged

Test filters context map & message builder #4886

merged 9 commits into from
Oct 13, 2023

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Oct 10, 2023

Description

  • Mock TwitchIrcServer & Channel in mocks & make getSevenTvBadges mockable
  • make getGIFTimer mockable/IAppable
  • use getIApp everywhere in TwitchMessageBuilder
  • remove useless getApp call in SharedMessageBuilder
  • test TwitchMessageBuilder::build
  • make getWatchingChannel mockable
  • add filter test making sure the context map is the correct length

@pajlada
Copy link
Member Author

pajlada commented Oct 10, 2023

Merging this in before the weekend, should help set up testing for the new incoming filters

github-actions[bot]
github-actions bot reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

mocks/include/mocks/EmptyApplication.hpp Show resolved Hide resolved
mocks/include/mocks/TwitchIrcServer.hpp Show resolved Hide resolved
mocks/include/mocks/TwitchIrcServer.hpp Show resolved Hide resolved
mocks/include/mocks/TwitchIrcServer.hpp Show resolved Hide resolved
tests/src/Filters.cpp Show resolved Hide resolved
tests/src/Filters.cpp Show resolved Hide resolved
tests/src/Filters.cpp Show resolved Hide resolved
tests/src/TwitchMessageBuilder.cpp Show resolved Hide resolved
tests/src/TwitchMessageBuilder.cpp Show resolved Hide resolved
@pajlada
Copy link
Member Author

pajlada commented Oct 13, 2023

image

@pajlada pajlada enabled auto-merge (squash) October 13, 2023 15:33
@pajlada pajlada merged commit 9f23c85 into master Oct 13, 2023
15 checks passed
@pajlada pajlada deleted the chore/mockify-more-stuff branch October 13, 2023 15:41
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pajlada